1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
|
// SPDX-FileCopyrightText: 2026 Stefan Majewsky <majewsky@gmx.net>
// SPDX-License-Identifier: Apache-2.0
package oblast_test
import (
"database/sql"
"strconv"
"testing"
"go.xyrillian.de/oblast"
"go.xyrillian.de/oblast/internal/assert"
"go.xyrillian.de/oblast/internal/mock"
"go.xyrillian.de/oblast/internal/must"
)
func TestInsertBasicUsingLastInsertId(t *testing.T) {
md := mock.NewDriver()
db := sql.OpenDB(md)
type basicRecord struct {
ID int64 `db:"id,auto"`
Name string `db:"name"`
}
store := oblast.MustNewStore[basicRecord](
oblast.SqliteDialect(),
oblast.TableNameIs("basic_records"),
oblast.PrimaryKeyIs("id"),
)
for _, batchSize := range []int{1, oblast.PrepareThreshold - 1, oblast.PrepareThreshold + 1} {
t.Run("N="+strconv.Itoa(batchSize), func(t *testing.T) {
records := make([]basicRecord, batchSize)
for idx := range batchSize {
records[idx] = basicRecord{Name: "new"}
md.ForQuery(`INSERT INTO "basic_records" ("name") VALUES (?)`).
ExpectExecWithArgs("new").
AndReturnLastInsertId(int64(42 + idx)).
AndReturnRowsAffected(1)
}
records = must.Return(store.Insert(db, records...))(t)
for idx, r := range records {
assert.Equal(t, r.ID, int64(42+idx))
}
})
}
}
func TestInsertBasicUsingReturningClause(t *testing.T) {
md := mock.NewDriver()
db := sql.OpenDB(md)
type basicRecord struct {
ID int64 `db:"id,auto"`
Name string `db:"name"`
}
store := oblast.MustNewStore[basicRecord](
oblast.PostgresDialect(),
oblast.TableNameIs("basic_records"),
oblast.PrimaryKeyIs("id"),
)
for _, batchSize := range []int{1, oblast.PrepareThreshold - 1, oblast.PrepareThreshold + 1} {
t.Run("N="+strconv.Itoa(batchSize), func(t *testing.T) {
records := make([]basicRecord, batchSize)
for idx := range batchSize {
records[idx] = basicRecord{Name: "new"}
md.ForQuery(`INSERT INTO "basic_records" ("name") VALUES ($1) RETURNING "id"`).
ExpectQueryWithArgs("new").
AndReturnColumns("id").
WithRow(int64(42 + idx))
}
records = must.Return(store.Insert(db, records...))(t)
for idx, r := range records {
assert.Equal(t, r.ID, int64(42+idx))
}
})
}
}
func TestUpdateBasic(t *testing.T) {
md := mock.NewDriver()
db := sql.OpenDB(md)
type basicRecord struct {
ID int64 `db:"id,auto"`
Name string `db:"name"`
}
store := oblast.MustNewStore[basicRecord](
oblast.SqliteDialect(),
oblast.TableNameIs("basic_records"),
oblast.PrimaryKeyIs("id"),
)
for _, batchSize := range []int{1, oblast.PrepareThreshold - 1, oblast.PrepareThreshold + 1} {
t.Run("N="+strconv.Itoa(batchSize), func(t *testing.T) {
records := make([]basicRecord, batchSize)
for idx := range batchSize {
r := basicRecord{ID: int64(42 + idx), Name: "updated"}
records[idx] = r
md.ForQuery(`UPDATE "basic_records" SET "name" = ? WHERE "id" = ?`).
ExpectExecWithArgs(r.Name, r.ID).
AndReturnRowsAffected(1)
}
must.Succeed(t, store.Update(db, records...))
})
}
}
func TestDeleteBasic(t *testing.T) {
md := mock.NewDriver()
db := sql.OpenDB(md)
type basicRecord struct {
ID int64 `db:"id,auto"`
Name string `db:"name"`
}
store := oblast.MustNewStore[basicRecord](
oblast.SqliteDialect(),
oblast.TableNameIs("basic_records"),
oblast.PrimaryKeyIs("id"),
)
for _, batchSize := range []int{1, oblast.PrepareThreshold - 1, oblast.PrepareThreshold + 1} {
t.Run("N="+strconv.Itoa(batchSize), func(t *testing.T) {
records := make([]basicRecord, batchSize)
for idx := range batchSize {
r := basicRecord{ID: int64(42 + idx), Name: "removed"}
records[idx] = r
md.ForQuery(`DELETE FROM "basic_records" WHERE "id" = ?`).
ExpectExecWithArgs(r.ID).
AndReturnRowsAffected(1)
}
must.Succeed(t, store.Delete(db, records...))
})
}
}
func TestWriteQueriesNotPossible(t *testing.T) {
md := mock.NewDriver()
db := sql.OpenDB(md)
type basicRecord struct {
ID int64 `db:"id,auto"`
Name string `db:"name"`
}
store := oblast.MustNewStore[basicRecord](
oblast.SqliteDialect(),
// no TableNameIs() or PrimaryKeyIs() given
)
r := basicRecord{Name: "foo"}
_, err := store.Insert(db, r)
assert.ErrEqual(t, err, "cannot execute Insert() because query could not be autogenerated")
r.ID = 42
err = store.Update(db, r)
assert.ErrEqual(t, err, "cannot execute Update() because query could not be autogenerated")
err = store.Delete(db, r)
assert.ErrEqual(t, err, "cannot execute Delete() because query could not be autogenerated")
}
func TestWriteQueriesFailDuringPrepare(t *testing.T) {
md := mock.NewDriver()
db := sql.OpenDB(md)
type basicRecord struct {
ID int64 `db:"id,auto"`
Name string `db:"name"`
}
store := oblast.MustNewStore[basicRecord](
oblast.SqliteDialect(),
oblast.TableNameIs("basic_records"),
oblast.PrimaryKeyIs("id"),
)
for _, batchSize := range []int{1, oblast.PrepareThreshold - 1, oblast.PrepareThreshold + 1} {
records := make([]basicRecord, batchSize)
for idx := range batchSize {
records[idx] = basicRecord{Name: "foo"}
}
_, err := store.Insert(db, records...)
baseError := `unexpected query: INSERT INTO "basic_records" ("name") VALUES (?)`
if batchSize < oblast.PrepareThreshold {
assert.ErrEqual(t, err, "during Exec() for record with idx = 0: "+baseError)
} else {
assert.ErrEqual(t, err, "during Prepare(): "+baseError)
}
for idx := range batchSize {
records[idx].ID = int64(42 + idx)
}
err = store.Update(db, records...)
baseError = `unexpected query: UPDATE "basic_records" SET "name" = ? WHERE "id" = ?`
if batchSize < oblast.PrepareThreshold {
assert.ErrEqual(t, err, "during Exec() for record with idx = 0: "+baseError)
} else {
assert.ErrEqual(t, err, "during Prepare(): "+baseError)
}
err = store.Delete(db, records...)
baseError = `unexpected query: DELETE FROM "basic_records" WHERE "id" = ?`
if batchSize < oblast.PrepareThreshold {
assert.ErrEqual(t, err, "during Exec() for record with idx = 0: "+baseError)
} else {
assert.ErrEqual(t, err, "during Prepare(): "+baseError)
}
}
store = oblast.MustNewStore[basicRecord](
oblast.PostgresDialect(), // for test coverage of insertUsingReturningClause()
oblast.TableNameIs("basic_records"),
oblast.PrimaryKeyIs("id"),
)
for _, batchSize := range []int{1, oblast.PrepareThreshold - 1, oblast.PrepareThreshold + 1} {
records := make([]basicRecord, batchSize)
for idx := range batchSize {
records[idx] = basicRecord{Name: "foo"}
}
_, err := store.Insert(db, records...)
baseError := `unexpected query: INSERT INTO "basic_records" ("name") VALUES ($1) RETURNING "id"`
if batchSize < oblast.PrepareThreshold {
assert.ErrEqual(t, err, "during QueryRow() for record with idx = 0: "+baseError)
} else {
assert.ErrEqual(t, err, "during Prepare(): "+baseError)
}
}
}
func TestUpdateFailsOnMissingRecord(t *testing.T) {
md := mock.NewDriver()
db := sql.OpenDB(md)
type basicRecord struct {
ID int64 `db:"id,auto"`
Name string `db:"name"`
}
store := oblast.MustNewStore[basicRecord](
oblast.SqliteDialect(),
oblast.TableNameIs("basic_records"),
oblast.PrimaryKeyIs("id"),
)
md.ForQuery(`UPDATE "basic_records" SET "name" = ? WHERE "id" = ?`).
ExpectExecWithArgs("changed", 42).
AndReturnRowsAffected(0)
err := store.Update(db, basicRecord{ID: 42, Name: "changed"})
assert.ErrEqual(t, err, "could not UPDATE record that does not exist in the database: id = 42")
_, hasCorrectType := err.(oblast.MissingRecordError[basicRecord]) //nolint:errorlint // we explicitly do not want a wrapped error
assert.Equal(t, hasCorrectType, true)
}
func TestInsertWithUnsignedIdField(t *testing.T) {
md := mock.NewDriver()
db := sql.OpenDB(md)
type basicRecord struct {
ID uint64 `db:"id,auto"` // not int64!
Name string `db:"name"`
}
t.Run("using LastInsertID", func(t *testing.T) {
store := oblast.MustNewStore[basicRecord](
oblast.SqliteDialect(),
oblast.TableNameIs("basic_records"),
oblast.PrimaryKeyIs("id"),
)
// success case
md.ForQuery(`INSERT INTO "basic_records" ("name") VALUES (?)`).
ExpectExecWithArgs("first").
AndReturnLastInsertId(42).
AndReturnRowsAffected(1)
records := must.Return(store.Insert(db, basicRecord{Name: "first"}))(t)
assert.SliceEqual(t, records, basicRecord{ID: 42, Name: "first"})
// error case: negative ID cannot be cast to uint64
md.ForQuery(`INSERT INTO "basic_records" ("name") VALUES (?)`).
ExpectExecWithArgs("second").
AndReturnLastInsertId(-42).
AndReturnRowsAffected(1)
_, err := store.Insert(db, basicRecord{Name: "second"})
assert.ErrEqual(t, err, "LastInsertId() = -42 for record with idx = 0 cannot be converted to uint")
// error case: cannot Insert() a record that already has its ID field filled
md.ForQuery(`INSERT INTO "basic_records" ("name") VALUES (?)`).
ExpectExecWithArgs("third").
AndReturnLastInsertId(42).
AndReturnRowsAffected(1)
_, err = store.Insert(db, basicRecord{ID: 23, Name: "third"})
assert.ErrEqual(t, err, `refusing to INSERT record with idx = 0 that already has non-zero values in its "auto" columns`)
})
t.Run("using RETURNING clause", func(t *testing.T) {
store := oblast.MustNewStore[basicRecord](
oblast.PostgresDialect(),
oblast.TableNameIs("basic_records"),
oblast.PrimaryKeyIs("id"),
)
// success case
md.ForQuery(`INSERT INTO "basic_records" ("name") VALUES ($1) RETURNING "id"`).
ExpectQueryWithArgs("first").
AndReturnColumns("id").
WithRow(42)
records := must.Return(store.Insert(db, basicRecord{Name: "first"}))(t)
assert.SliceEqual(t, records, basicRecord{ID: 42, Name: "first"})
// error case: negative ID cannot be cast to uint64
md.ForQuery(`INSERT INTO "basic_records" ("name") VALUES ($1) RETURNING "id"`).
ExpectQueryWithArgs("second").
AndReturnColumns("id").
WithRow(-42)
_, err := store.Insert(db, basicRecord{Name: "second"})
assert.ErrEqual(t, err, `during QueryRow() for record with idx = 0: sql: Scan error on column index 0, name "id": converting driver.Value type int ("-42") to a uint64: invalid syntax`)
// error case: cannot Insert() a record that already has its ID field filled
md.ForQuery(`INSERT INTO "basic_records" ("name") VALUES ($1) RETURNING "id"`).
ExpectQueryWithArgs("third").
AndReturnColumns("id").
WithRow(42)
_, err = store.Insert(db, basicRecord{ID: 23, Name: "third"})
assert.ErrEqual(t, err, `refusing to INSERT record with idx = 0 that already has non-zero values in its "auto" columns`)
})
}
|
