diff options
| author | Stefan Majewsky <majewsky@gmx.net> | 2018-03-11 19:38:27 +0100 |
|---|---|---|
| committer | Stefan Majewsky <majewsky@gmx.net> | 2018-03-11 19:41:33 +0100 |
| commit | d23b4052c0866698b14ac13ac98581d9f5440a9b (patch) | |
| tree | 51c93559594f8fd5136fd51b7397a30415ea93aa /container_iterator.go | |
| parent | aaf61ac55e18a04fd68b9b6ee4fd4fce49659eeb (diff) | |
| download | go-schwift-d23b4052c0866698b14ac13ac98581d9f5440a9b.tar.gz | |
revamp the Headers API
1. Move common methods of AccountHeaders, ContainerHeaders,
ObjectHeaders into a base type Headers.
2. Fold Headers into RequestOptions to remove one of the two optional
arguments on request methods. The new Headers.ToOpts() method
offers a nice experience for users passing Headers to request
methods.
The Update() methods keep the explicit Headers argument since the
Headers argument is not optional there.
The only downside is that we lose a bit of type-safety because
RequestOptions takes any Headers instance, so e.g. ContainerHeaders
could be passed to Object.Upload(). I believe the benefits outweigh
this problem.
Diffstat (limited to 'container_iterator.go')
| -rw-r--r-- | container_iterator.go | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/container_iterator.go b/container_iterator.go index c428335..debe475 100644 --- a/container_iterator.go +++ b/container_iterator.go @@ -64,9 +64,7 @@ type ContainerIterator struct { //When Prefix is set, only containers whose name starts with this string are //returned. Prefix string - //Headers may contain additional headers to include with the GET request. - Headers map[string]string - //Options may contain additional query parameters for the GET request. + //Options may contain additional headers and query parameters for the GET request. Options *RequestOptions base *iteratorBase |