diff options
| author | Stefan Majewsky <majewsky@gmx.net> | 2018-03-11 19:38:27 +0100 |
|---|---|---|
| committer | Stefan Majewsky <majewsky@gmx.net> | 2018-03-11 19:41:33 +0100 |
| commit | d23b4052c0866698b14ac13ac98581d9f5440a9b (patch) | |
| tree | 51c93559594f8fd5136fd51b7397a30415ea93aa /field_metadata.go | |
| parent | aaf61ac55e18a04fd68b9b6ee4fd4fce49659eeb (diff) | |
| download | go-schwift-d23b4052c0866698b14ac13ac98581d9f5440a9b.tar.gz | |
revamp the Headers API
1. Move common methods of AccountHeaders, ContainerHeaders,
ObjectHeaders into a base type Headers.
2. Fold Headers into RequestOptions to remove one of the two optional
arguments on request methods. The new Headers.ToOpts() method
offers a nice experience for users passing Headers to request
methods.
The Update() methods keep the explicit Headers argument since the
Headers argument is not optional there.
The only downside is that we lose a bit of type-safety because
RequestOptions takes any Headers instance, so e.g. ContainerHeaders
could be passed to Object.Upload(). I believe the benefits outweigh
this problem.
Diffstat (limited to 'field_metadata.go')
| -rw-r--r-- | field_metadata.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/field_metadata.go b/field_metadata.go index 05dee32..90993d4 100644 --- a/field_metadata.go +++ b/field_metadata.go @@ -22,12 +22,12 @@ package schwift //in a headers instance. It cannot be directly constructed, but each headers //type has a method "Metadata" returning this type. For example: // -// hdr := make(ObjectHeaders) -// //the following two statements are equivalent -// hdr["X-Object-Meta-Access"] = "strictly confidential" -// hdr.Metadata().Set("Access", "strictly confidential") +// hdr := NewObjectHeaders() +// //the following two statements are equivalent +// hdr["X-Object-Meta-Access"] = "strictly confidential" +// hdr.Metadata().Set("Access", "strictly confidential") type FieldMetadata struct { - h headerInterface + h Headers k string } |
