aboutsummaryrefslogtreecommitdiff
path: root/object_iterator.go
diff options
context:
space:
mode:
authorStefan Majewsky <majewsky@gmx.net>2018-03-11 19:38:27 +0100
committerStefan Majewsky <majewsky@gmx.net>2018-03-11 19:41:33 +0100
commitd23b4052c0866698b14ac13ac98581d9f5440a9b (patch)
tree51c93559594f8fd5136fd51b7397a30415ea93aa /object_iterator.go
parentaaf61ac55e18a04fd68b9b6ee4fd4fce49659eeb (diff)
downloadgo-schwift-d23b4052c0866698b14ac13ac98581d9f5440a9b.tar.gz
revamp the Headers API
1. Move common methods of AccountHeaders, ContainerHeaders, ObjectHeaders into a base type Headers. 2. Fold Headers into RequestOptions to remove one of the two optional arguments on request methods. The new Headers.ToOpts() method offers a nice experience for users passing Headers to request methods. The Update() methods keep the explicit Headers argument since the Headers argument is not optional there. The only downside is that we lose a bit of type-safety because RequestOptions takes any Headers instance, so e.g. ContainerHeaders could be passed to Object.Upload(). I believe the benefits outweigh this problem.
Diffstat (limited to 'object_iterator.go')
-rw-r--r--object_iterator.go6
1 files changed, 2 insertions, 4 deletions
diff --git a/object_iterator.go b/object_iterator.go
index 6d93ccf..3df03dd 100644
--- a/object_iterator.go
+++ b/object_iterator.go
@@ -65,12 +65,10 @@ type ObjectIterator struct {
//When Prefix is set, only objects whose name starts with this string are
//returned.
Prefix string
- //Headers may contain additional headers to include with the GET request.
- Headers map[string]string
- //Options may contain additional query parameters for the GET request.
+ //Options may contain additional headers and query parameters for the GET request.
Options *RequestOptions
- //TODO: Delimter field (and check if other stuff is missing)
+ //TODO: Delimiter field (and check if other stuff is missing)
base *iteratorBase
}