From f9749638e3393f471d7e28362795689bf37cc023 Mon Sep 17 00:00:00 2001 From: Stefan Majewsky Date: Mon, 30 Apr 2018 14:14:56 +0200 Subject: revamp the LargeObject API I thought about this some more, and I believe the Writer-based approach in the previous version of the LargeObject API does not scale: It makes it very hard to write code that uploads segments without resorting to a buffer the same size as the segments. I don't want gigabyte-scale buffers filling up my RAM, so this commit switches to a different API based on Readers. LargeObject.Append() now behaves very similar to Object.Upload(), which I find quite nice. --- tests/object_iterator_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/object_iterator_test.go') diff --git a/tests/object_iterator_test.go b/tests/object_iterator_test.go index 009189d..9b822cd 100644 --- a/tests/object_iterator_test.go +++ b/tests/object_iterator_test.go @@ -39,7 +39,7 @@ func TestObjectIterator(t *testing.T) { for idx := 1; idx <= 4; idx++ { hdr := schwift.NewObjectHeaders() hdr.ContentType().Set("application/json") - err := c.Object(oname(idx)).Upload(bytes.NewReader(objectExampleContent), hdr.ToOpts()) + err := c.Object(oname(idx)).Upload(bytes.NewReader(objectExampleContent), nil, hdr.ToOpts()) expectSuccess(t, err) } -- cgit v1.2.3